[ipxe-devel] [ipxe/ipxe] [crypto/OCSP] parse response certID for validation (#90)

[Christian Nilsson]

I'm confused how ipxe.pxe seems smaller in your tests with this branch(?)
my own tests for buildsize ...
this branch is 83c744d68802
master is 36a4c85f911c85
I find it weird that no https versions seems to be affected (sometimes) as well, I have tried several times now and always getting the same result, so not sure what's going on - this is not important from the code/PR standpoint, just an observation that I can't explain ;)

bin/ipxe.pxe
no https master: 331336
no https this branch: 331462
https master: 343210
https this branch: 343509

bin/intel.rom
no https master: 68096
no https this branch: 68096
https master: 82432
https this branch: 82944

bin/undionly.kpxe
no https master: 67195
no https this branch: 67192
https master: 81888
https this branch: 81950

bin-x86_64-efi/snponly.efi
no https master: 155168
no https this branch: 155168
https master: 188544
https this branch: 188928

Hack of script to simplify testing
```dstfile=bin/ipxe.pxe
#dstfile=bin/intel.rom
#dstfile=bin/undionly.kpxe
#dstfile=bin-x86_64-efi/snponly.efi

basemake="make -j16 $dstfile"
git fetch https://github.com/kinvolk/ipxe.git t-lo/ocsp-certid-parsing
git checkout FETCH_HEAD
git rebase origin/master
git log -1  --pretty=oneline | cat
$basemake CONFIG=none > /dev/null; ls -l $dstfile
$basemake CONFIG=https > /dev/null; ls -l $dstfile
git checkout origin/master
git log -1  --pretty=oneline | cat
$basemake CONFIG=none > /dev/null; ls -l $dstfile
$basemake CONFIG=https > /dev/null; ls -l $dstfile
```

named configs diff:
```~/ipxe/src $ diff -ur config/local/none/ config/local/https/
diff -ur config/local/none/general.h config/local/https/general.h
--- config/local/none/general.h 2019-02-16 14:35:40.217373291 +0100
+++ config/local/https/general.h        2019-02-16 14:35:26.341373344 +0100
@@ -0,0 +1 @@
+#define        DOWNLOAD_PROTO_HTTPS    /* Secure Hypertext Transfer Protocol */
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ipxe/ipxe/pull/90#issuecomment-464348561
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ipxe.org/pipermail/ipxe-devel/attachments/20190216/3b7f5794/attachment.htm>