<p>I'm confused how ipxe.pxe seems smaller in your tests with this branch(?)<br>
my own tests for buildsize ...<br>
this branch is <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/ipxe/ipxe/commit/83c744d68802720e105362989e685fe793e6097b/hovercard" href="https://github.com/ipxe/ipxe/commit/83c744d68802720e105362989e685fe793e6097b"><tt>83c744d</tt></a><br>
master is <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/ipxe/ipxe/commit/36a4c85f911c85f5ab183331ff74d125f9a9ed32/hovercard" href="https://github.com/ipxe/ipxe/commit/36a4c85f911c85f5ab183331ff74d125f9a9ed32"><tt>36a4c85</tt></a><br>
I find it weird that no https versions seems to be affected (sometimes) as well, I have tried several times now and always getting the same result, so not sure what's going on - this is not important from the code/PR standpoint, just an observation that I can't explain ;)</p>
<p>bin/ipxe.pxe<br>
no https master: 331336<br>
no https this branch: 331462<br>
https master: 343210<br>
https this branch: 343509</p>
<p>bin/intel.rom<br>
no https master: 68096<br>
no https this branch: 68096<br>
https master: 82432<br>
https this branch: 82944</p>
<p>bin/undionly.kpxe<br>
no https master: 67195<br>
no https this branch: 67192<br>
https master: 81888<br>
https this branch: 81950</p>
<p>bin-x86_64-efi/snponly.efi<br>
no https master: 155168<br>
no https this branch: 155168<br>
https master: 188544<br>
https this branch: 188928</p>
<p>Hack of script to simplify testing</p>
<pre lang="dstfile=bin/ipxe.pxe"><code>#dstfile=bin/intel.rom
#dstfile=bin/undionly.kpxe
#dstfile=bin-x86_64-efi/snponly.efi

basemake="make -j16 $dstfile"
git fetch https://github.com/kinvolk/ipxe.git t-lo/ocsp-certid-parsing
git checkout FETCH_HEAD
git rebase origin/master
git log -1  --pretty=oneline | cat
$basemake CONFIG=none > /dev/null; ls -l $dstfile
$basemake CONFIG=https > /dev/null; ls -l $dstfile
git checkout origin/master
git log -1  --pretty=oneline | cat
$basemake CONFIG=none > /dev/null; ls -l $dstfile
$basemake CONFIG=https > /dev/null; ls -l $dstfile
</code></pre>
<p>named configs diff:</p>
<pre lang="~/ipxe/src" data-meta="$ diff -ur config/local/none/ config/local/https/"><code>diff -ur config/local/none/general.h config/local/https/general.h
--- config/local/none/general.h 2019-02-16 14:35:40.217373291 +0100
+++ config/local/https/general.h        2019-02-16 14:35:26.341373344 +0100
@@ -0,0 +1 @@
+#define        DOWNLOAD_PROTO_HTTPS    /* Secure Hypertext Transfer Protocol */
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/ipxe/ipxe/pull/90#issuecomment-464348561">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AArTVCyw-GclV6clcWKu6BDShnyHCV01ks5vOAwkgaJpZM4a-EdD">mute the thread</a>.<img src="https://github.com/notifications/beacon/AArTVILGn3jAakFR_3unpyik_R0-kOZCks5vOAwkgaJpZM4a-EdD.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/ipxe/ipxe","title":"ipxe/ipxe","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/ipxe/ipxe"}},"updates":{"snippets":[{"icon":"PERSON","message":"@NiKiZe in #90: I'm confused how ipxe.pxe seems smaller in your tests with this branch(?)\r\nmy own tests for buildsize ...\r\nthis branch is 83c744d68802\r\nmaster is 36a4c85f911c85\r\nI find it weird that no https versions seems to be affected (sometimes) as well, I have tried several times now and always getting the same result, so not sure what's going on - this is not important from the code/PR standpoint, just an observation that I can't explain ;)\r\n\r\nbin/ipxe.pxe\r\nno https master: 331336\r\nno https this branch: 331462\r\nhttps master: 343210\r\nhttps this branch: 343509\r\n\r\nbin/intel.rom\r\nno https master: 68096\r\nno https this branch: 68096\r\nhttps master: 82432\r\nhttps this branch: 82944\r\n\r\nbin/undionly.kpxe\r\nno https master: 67195\r\nno https this branch: 67192\r\nhttps master: 81888\r\nhttps this branch: 81950\r\n\r\nbin-x86_64-efi/snponly.efi\r\nno https master: 155168\r\nno https this branch: 155168\r\nhttps master: 188544\r\nhttps this branch: 188928\r\n\r\nHack of script to simplify testing\r\n```dstfile=bin/ipxe.pxe\r\n#dstfile=bin/intel.rom\r\n#dstfile=bin/undionly.kpxe\r\n#dstfile=bin-x86_64-efi/snponly.efi\r\n\r\nbasemake=\"make -j16 $dstfile\"\r\ngit fetch https://github.com/kinvolk/ipxe.git t-lo/ocsp-certid-parsing\r\ngit checkout FETCH_HEAD\r\ngit rebase origin/master\r\ngit log -1  --pretty=oneline | cat\r\n$basemake CONFIG=none \u003e /dev/null; ls -l $dstfile\r\n$basemake CONFIG=https \u003e /dev/null; ls -l $dstfile\r\ngit checkout origin/master\r\ngit log -1  --pretty=oneline | cat\r\n$basemake CONFIG=none \u003e /dev/null; ls -l $dstfile\r\n$basemake CONFIG=https \u003e /dev/null; ls -l $dstfile\r\n```\r\n\r\nnamed configs diff:\r\n```~/ipxe/src $ diff -ur config/local/none/ config/local/https/\r\ndiff -ur config/local/none/general.h config/local/https/general.h\r\n--- config/local/none/general.h 2019-02-16 14:35:40.217373291 +0100\r\n+++ config/local/https/general.h        2019-02-16 14:35:26.341373344 +0100\r\n@@ -0,0 +1 @@\r\n+#define        DOWNLOAD_PROTO_HTTPS    /* Secure Hypertext Transfer Protocol */\r\n```"}],"action":{"name":"View Pull Request","url":"https://github.com/ipxe/ipxe/pull/90#issuecomment-464348561"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/ipxe/ipxe/pull/90#issuecomment-464348561",
"url": "https://github.com/ipxe/ipxe/pull/90#issuecomment-464348561",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>