[ipxe-devel] [ipxe/ipxe] [hci] Add timeout arg to ifconf (#96)

[Joe Groocock]

frebib commented on this pull request.



> @@ -202,6 +204,9 @@ static struct option_descriptor ifconf_opts[] = {
 	OPTION_DESC ( "configurator", 'c', required_argument,
 		      struct ifconf_options, configurator,
 		      parse_netdev_configurator ),
+	OPTION_DESC ( "timeout", 't', required_argument,

I chose `timeout` to stay consistent with the rest of the user commands:
```
$ rg \"timeout\"
src/image/script.c
375:	OPTION_DESC ( "timeout", 't', required_argument,

src/hci/commands/sync_cmd.c
47:	OPTION_DESC ( "timeout", 't', required_argument,

src/hci/commands/ping_cmd.c
65:	OPTION_DESC ( "timeout", 't', required_argument,

src/hci/commands/menu_cmd.c
213:	OPTION_DESC ( "timeout", 't', required_argument,

src/hci/commands/image_trust_cmd.c
103:	OPTION_DESC ( "timeout", 't', required_argument,

src/hci/commands/image_cmd.c
67:		OPTION_DESC ( "timeout", 't', required_argument,```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ipxe/ipxe/pull/96#discussion_r361844053
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ipxe.org/pipermail/ipxe-devel/attachments/20191229/16ef4328/attachment.htm>