[ipxe-devel] [ipxe/ipxe] [build] Do not use random build_ids (#82)
Christian Nilsson
notifications at github.com
Wed Oct 24 12:08:38 UTC 2018
Commit that introduced this feature: https://git.ipxe.org/ipxe.git/commitdiff/58f6e553625c90d928ddd54b8f31634a5b26f05e
Each ROM have a need for identifier per build
This is described by @mcb30 at http://lists.ipxe.org/pipermail/ipxe-devel/2015-February/003978.html as well - I'm reading as using checksum here is not acceptable.
Also the comment above the rand line says this:
#... Must be unique for each $(BIN)/%.tmp,
# even within the same build run.
if checksum is used that comment needs update as well?
A patch that makes this stable for non roms would probably be acceptable, but for roms it won't be unless the reason for the buildids existence is solved some other way instead.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ipxe/ipxe/pull/82#issuecomment-432629171
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ipxe.org/pipermail/ipxe-devel/attachments/20181024/a5955e1d/attachment.htm>
More information about the ipxe-devel
mailing list