<p>Commit that introduced this feature: <a href="https://git.ipxe.org/ipxe.git/commitdiff/58f6e553625c90d928ddd54b8f31634a5b26f05e" rel="nofollow">https://git.ipxe.org/ipxe.git/commitdiff/58f6e553625c90d928ddd54b8f31634a5b26f05e</a></p>
<p>Each ROM have a need for identifier per build<br>
This is described by <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=692245" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/mcb30">@mcb30</a> at <a href="http://lists.ipxe.org/pipermail/ipxe-devel/2015-February/003978.html" rel="nofollow">http://lists.ipxe.org/pipermail/ipxe-devel/2015-February/003978.html</a> as well - I'm reading as using checksum here is not acceptable.</p>
<p>Also the comment above the rand line says this:<br>
#... Must be unique for each $(BIN)/%.tmp,</p>
<h1>even within the same build run.</h1>
<p>if checksum is used that comment needs update as well?</p>
<p>A patch that makes this stable for non roms would probably be acceptable, but for roms it won't be unless the reason for the buildids existence is solved some other way instead.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/ipxe/ipxe/pull/82#issuecomment-432629171">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AArTVLgabNPQHH5Z4r3hZoeGpKbf9_FGks5uoFhGgaJpZM4X3UjH">mute the thread</a>.<img src="https://github.com/notifications/beacon/AArTVCeJ_15GPBbGYCrxejEDchI0Av5Qks5uoFhGgaJpZM4X3UjH.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/ipxe/ipxe","title":"ipxe/ipxe","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/ipxe/ipxe"}},"updates":{"snippets":[{"icon":"PERSON","message":"@NiKiZe in #82: Commit that introduced this feature: https://git.ipxe.org/ipxe.git/commitdiff/58f6e553625c90d928ddd54b8f31634a5b26f05e\r\n\r\nEach ROM have a need for identifier per build\r\nThis is described by @mcb30 at http://lists.ipxe.org/pipermail/ipxe-devel/2015-February/003978.html as well - I'm reading as using checksum here is not acceptable.\r\n\r\nAlso the comment above the rand line says this:\r\n#... Must be unique for each $(BIN)/%.tmp,\r\n# even within the same build run.\r\nif checksum is used that comment needs update as well?\r\n\r\nA patch that makes this stable for non roms would probably be acceptable, but for roms it won't be unless the reason for the buildids existence is solved some other way instead."}],"action":{"name":"View Pull Request","url":"https://github.com/ipxe/ipxe/pull/82#issuecomment-432629171"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/ipxe/ipxe/pull/82#issuecomment-432629171",
"url": "https://github.com/ipxe/ipxe/pull/82#issuecomment-432629171",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [ipxe/ipxe] [build] Do not use random build_ids (#82)",
"sections": [
{
"text": "",
"activityTitle": "**Christian Nilsson**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@NiKiZe",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"ipxe/ipxe\",\n\"issueId\": 82,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"ipxe/ipxe\",\n\"pullRequestId\": 82\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/ipxe/ipxe/pull/82#issuecomment-432629171"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 400378055\n}"
}
],
"themeColor": "26292E"
}
]</script>