[ipxe-devel] Apple EFI SNP set ReceiveFilters patch

[Jarrod Johnson]

For what it is worth, when this change got committed ESXi 5.5 guest with
vmxnet3 starts working too.  For some reason at first glance the loaded
image does not
see the ipxe download protocol, haven't gotten to look into that yet...



On Tue, Aug 5, 2014 at 12:30 AM, Curtis Larsen <larsen at dixie.edu> wrote:

> Attached is the git diff for changes necessary to make the Apple EFI
> allow SNP->ReceiveFilters to actually set SNP->RecieveFilterSetting.
>
> Also included in the patch are a debugging routine to display the
> SNP->Mode structure, a modification to snpnet_poll_rx to check if there
> is something to receive, a possible typo correction in snpnet_poll_tx,
> Michael Brown's change to open EFI driver protocols by GET_PROTOCOL, and
> a debugging check for failed calls to DisconnectController.
>
> The behavior seen in the Apple EFI (1.10) on SNP->RecieveFilters is:
> - Failure if any of the PROMISCUOUS or MULTICAST filters are included
> - Success if only UNICAST is included, however the result is UNICAST |
> BROADCAST
> - Success if only UNICAST and BROADCAST are included
> - If UNICAST, or UNICAST|BROADCAST are used, but the previous call tried
> (and failed) to set UNICAST|BROADCAST|MULTICAST, then the result is
> UNICAST|BROADCAST|MULTICAST
>
> Yes, this sounds broken to me, but it's the way it works.
>
> So, the modified code does tries using SNP->RecieveFilterMask, then
> falls back to UNICAST|BROADCAST|MULTICAST, then UNICAST|BROADCAST, and
> finally UNICAST.
>
> I'd be happy to do any further testing, or to clean up the code anyway
> you'd like.
>
> Sorry, I didn't configure my editor for tabbed spacing, so I hope you
> have a pretty-printer to filter through.
>
> Thanks,
>
> Curtis Larsen
>
>
> _______________________________________________
> ipxe-devel mailing list
> ipxe-devel at lists.ipxe.org
> https://lists.ipxe.org/mailman/listinfo.cgi/ipxe-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ipxe.org/pipermail/ipxe-devel/attachments/20140805/b13059ef/attachment.htm>