[ipxe-devel] REG: Query on 9K MTU Testing flow

[Michael Brown]

On 14/03/2023 16:45, MohamedShah R wrote:
> Thanks for the quick response. I am new to the PXE source code and tried 
> out the below changes  for the experimental testing in the netdev_close 
> api and it works fine.
> Why can't we have a new api netdev_reopen() which does the same logic of 
> netdev_close (except the code below) and calls the netdev_open existing 
> api and calls the netdev_reopen api only from the "apply_netdev_settings".
> Would it have any other side-effects? Please correct me if I am wrong.
> 
> *Commented out the below code in netdev_close api *
>       num_configs = table_num_entries ( NET_DEVICE_CONFIGURATORS );
> 
> for ( i = 0 ; i < num_configs ; i++ )
> 
> intf_close ( &netdev->configs[i].job, -ECANCELED );

As per my previous email: even with that hack in place, there will still 
be unwanted side effects from calling netdev->op->close() and 
netdev->op->open(), such as restarting autonegotiation on the link (with 
some drivers).

Michael