[ipxe-devel] [ipxe/ipxe] Setup INT13 partition on usb images only ifdef CONSOLE_INT13 (#106)

Robien notifications at github.com
Sun Feb 23 23:45:33 UTC 2020


> The patch feels wrong, surely **no** _Looks Good To Me_.

Can you elaborate a bit so I can make it better? Do you think I should add an option?

I should have also say that the code I am adding here comes from an older version of the file where CONSOLE_INT13 wasn't implemented yet (so no new code is introduced here)

We are using ipxe inside a very small device and we need that extra 1Mb. I understand that is not very important for the majority of users but this patch doesn't take anything to anyone.

-- 
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/ipxe/ipxe/pull/106#issuecomment-590130930
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ipxe.org/pipermail/ipxe-devel/attachments/20200223/4f002779/attachment.htm>


More information about the ipxe-devel mailing list