[ipxe-devel] [PATCH 1/2] [efi] Fix "'%s' directive argument is null" error

Valentine Barshak gvaxon at gmail.com
Thu May 30 17:38:43 UTC 2019


Use '%p' directive, and print handle's address if the
address is null and the handle doesn't have a name.
This fixes the following compilation error:

  interface/efi/efi_debug.c:334:3: error: '%s' directive
  argument is null [-Werror=format-overflow=]

Signed-off-by: Valentine Barshak <gvaxon at gmail.com>
---
 src/interface/efi/efi_debug.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/interface/efi/efi_debug.c b/src/interface/efi/efi_debug.c
index 8ea0a822..e298c8f9 100644
--- a/src/interface/efi/efi_debug.c
+++ b/src/interface/efi/efi_debug.c
@@ -331,8 +331,7 @@ void dbg_efi_protocols ( EFI_HANDLE handle ) {
 
 	/* Sanity check */
 	if ( ! handle ) {
-		printf ( "HANDLE %s could not retrieve protocols\n",
-			 efi_handle_name ( handle ) );
+		printf ( "HANDLE %p could not retrieve protocols\n", handle);
 		return;
 	}
 
-- 
2.21.0




More information about the ipxe-devel mailing list