[ipxe-devel] [PATCH] [serial] Allow serial port configuration at runtime

[Ján ONDREJ (SAL)]

On Sun, Jun 16, 2019 at 03:46:18PM +0300, Faidon Liambotis wrote:
> On Sun, Jun 16, 2019 at 05:44:20AM +0200, Ján ONDREJ (SAL) wrote:
> > Just for backward compatibility it would be nice to predefine
> > serial-port and serial-options variables by settings from C #defines.
> > My recompiled binaries are not working as before you patch. Need to
> > set at least serial-port variable manually.
> 
> The intention is that this should work. How does your build-time config
> look like? Here I get serial port output if I do:
>   echo '#define CONSOLE_SERIAL'  > src/config/local/console.h
>   echo '#define COMCONSOLE COM1' > src/config/local/serial.h

OK, looks like when no COMCONSOLE is defined in serial.h, then ipxe master
uses COM1 as serial console and you patch is using "no serial console".
I updated my serial configs on boot.salstar.sk. Not sure how this affects
other usesrs. Still I like this patch.

							SAL