[ipxe-devel] [PATCH 1/4] Fix strcmp()/strncmp() to return proper values

Michael Brown mcb30 at ipxe.org
Tue Jan 15 14:15:53 UTC 2019


On 09/01/2019 19:35, Aaron Young wrote:
> Fix strcmp() and strncmp() to return proper standard
> positive/negative values for unequal strings. Current implementation is
> backwards (i.e. the functions are returning negative when should be position
> and vice-versa).
> 
> Currently all consumers of these functions only check the return
> value for ==0 or !=0 and so we can safely change the
> implementation without breaking things.

Applied with an additional unit test as

   http://git.ipxe.org/ipxe.git/commitdiff/3946aa9ba

Thanks,

Michael



More information about the ipxe-devel mailing list