[ipxe-devel] [ipxe/ipxe] [crypto/OCSP] parse response certID for validation (#90)

[Geert Stappers]

> Tell us what needs improvement.

The easy part
* Don't make white space changes
* Keep   `/* comment */` style,  don't introduce    `//  comment`  style


The
```
-       struct asn1_cursor cursor;
+	struct asn1_cursor req, resp;
```
makes it hard to read what is actually added.

I can't see if the  unsqaushed commits made more clear what is added. It is gone in the update of this pull request.

I think the commit message would come better if the thrid line would start with
(Thrid line:   First line is "commit summary", second line is empty )
```
Implements parsing of all certID fields of incoming OCSP
responses as well as validation of the field values against the
respective request field values.
```


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/ipxe/ipxe/pull/90#issuecomment-466655654
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ipxe.org/pipermail/ipxe-devel/attachments/20190223/05613d35/attachment.htm>