[ipxe-devel] [PATCH 1/1] [build] Don't use -mabi=lp64 for HOSTCC

[Heinrich Schuchardt]

Hello Michael,

this patch still is needed to build bin-arm64-efi/snp.efi.

Any reason why this cannot be merged?

Best regards

Heinrich

On 08/25/2018 08:06 AM, Heinrich Schuchardt wrote:
> Patch 1c47eb186e7e ("[build] Conditionalise use of -mabi=lp64 for ARM64
> builds") causes HOSTCC util/elf2efi64 to be called with -mabi=lp64
> which is illegal on the amd64 architecture:
> 
> [HOSTCC] util/elf2efi64
> gcc: error: unrecognized argument in option ‘-mabi=lp64’
> gcc: note: valid arguments to ‘-mabi=’ are: ms sysv
> make[3]: *** [Makefile.housekeeping:1397: util/elf2efi64] Error 1
> 
> Fixed: 1c47eb186e7e ("[build] Conditionalise use of -mabi=lp64 for ARM64
> builds")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> ---
>  src/arch/arm64/Makefile | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/src/arch/arm64/Makefile b/src/arch/arm64/Makefile
> index 9b9dd5ec..388dcd32 100644
> --- a/src/arch/arm64/Makefile
> +++ b/src/arch/arm64/Makefile
> @@ -16,7 +16,6 @@ ASFLAGS		+= -mabi=lp64 -EL
>  ifeq ($(CCTYPE),gcc)
>  LP64_TEST = $(CC) -mabi=lp64 -x c -c /dev/null -o /dev/null >/dev/null 2>&1
>  LP64_FLAGS := $(shell $(LP64_TEST) && $(ECHO) '-mabi=lp64')
> -WORKAROUND_CFLAGS += $(LP64_FLAGS)
>  endif
>  
>  # EFI requires -fshort-wchar, and nothing else currently uses wchar_t
>