[ipxe-devel] [PATCH] vmbus: do not expect version in version_response

Michael Brown mcb30 at ipxe.org
Sun Jul 8 00:48:17 BST 2018


On 09/06/18 15:53, Roman Kagan wrote:
> The definition of version_response channel message in Linux doesn't
> include version field, so the upcoming VMBus implementation in QEMU
> doesn't set it either.  Neither Windows nor Linux had any problem with
> this.
> 
> The check against this field is redundant because the message is the
> response to initiate_contact message containing the specific version
> requested, so the response with version_supported=true is unambiguous.
> 
> Drop this check and don't rely on the field to be present in the
> message.

Applied (with minor change to avoid use of magic numbers):

   http://git.ipxe.org/ipxe.git/commitdiff/40956545e

Thanks!

Michael


More information about the ipxe-devel mailing list