[ipxe-devel] [PATCH v3 2/3] [virtio] Renumber virtio_pci_region flags

Ladi Prosek lprosek at redhat.com
Mon May 2 15:41:31 UTC 2016

Some of the regions may end up being unmapped, either because
they are optional or because the attempt to map them has failed.
Region types starting at 0 didn't make it easy to test for this

This commit bumps all valid region types up by 1 with 0 having
the implicit 'unmapped' meaning.

Signed-off-by: Ladi Prosek <lprosek at redhat.com>
 src/include/ipxe/virtio-pci.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/include/ipxe/virtio-pci.h b/src/include/ipxe/virtio-pci.h
index c7452c8..f3c9b17 100644
--- a/src/include/ipxe/virtio-pci.h
+++ b/src/include/ipxe/virtio-pci.h
@@ -107,11 +107,11 @@ struct virtio_pci_region {
 /* How to interpret the base field */
 #define VIRTIO_PCI_REGION_TYPE_MASK  0x00000003
 /* The base field is a memory address */
-#define VIRTIO_PCI_REGION_MEMORY     0x00000000
+#define VIRTIO_PCI_REGION_MEMORY     0x00000001
 /* The base field is a port address */
-#define VIRTIO_PCI_REGION_PORT       0x00000001
+#define VIRTIO_PCI_REGION_PORT       0x00000002
 /* The base field is an offset within the PCI bar */
-#define VIRTIO_PCI_REGION_PCI_CONFIG 0x00000002
+#define VIRTIO_PCI_REGION_PCI_CONFIG 0x00000003
     unsigned flags;

More information about the ipxe-devel mailing list