[ipxe-devel] [PATCH v2 0/3] [virtio] Enable and restore PCI device correctly

Ladi Prosek lprosek at redhat.com
Mon May 2 13:11:03 UTC 2016

This series is a follow-up to our virtio 1.0 discussion. The
first patch adds two new functions as suggested by Michael and
the third one makes virtio-net call them.

Changes v1->v2:

* fixed comment 'busmaster' -> 'bus master'
* renamed functions 'enable_pci_device' -> 'pci_enable_device',
  'disable_pci_device' -> 'pci_restore_device'
* pci_enable_device takes the desired latency timer value in argument,
  special value of 0 makes it not touch the register
* tweaked debug output of pci_enable_device: 'device not enabled by
  BIOS!' -> 'device not fully enabled by BIOS!'
* new debug output in pci_restore_device: 'restoring PCI command to ..'
* new helper function for region type testing: virtnet_uses_region_type
* added a patch to renumber virtio_pci_region flags so they make more
  sense; this also fixes a bug where virtio_pci_unmap_capability could
  call iounmap on an uninitialized region
* adjusted commit messages

I believe that I addressed all v1 comments, please let me know otherwise.


 src/drivers/bus/pci.c         | 58 +++++++++++++++++++++++++++++++++++--------
 src/drivers/bus/virtio-pci.c  | 10 ++++++++
 src/drivers/net/virtio-net.c  | 41 ++++++++++++++++++++++++++++--
 src/include/ipxe/pci.h        |  3 +++
 src/include/ipxe/virtio-pci.h |  8 +++---
 5 files changed, 105 insertions(+), 15 deletions(-)

More information about the ipxe-devel mailing list