[ipxe-devel] [PATCH 0/2] [virtio] Enable and disable PCI device correctly

[Marcel Apfelbaum]

On 04/28/2016 06:34 PM, Ladi Prosek wrote:
> This series is a follow-up to our virtio 1.0 discussion. The
> first patch adds two new functions as suggested by Michael and
> the second one makes virtio-net call them.
>
> CC'ing Marcel who may be interested in this (keywords: BIOS,
> PCI, BAR :)

Hi Ladi,
I agree with what the series want to achieve,
however I do have some comments, please take them as suggestions only
and remember that you asked for them :)

Thanks,
Marcel

>
> Thanks!
> Ladi
>
> [PATCH 1/2] [pci] Add enable_pci_device and disable_pci_device
> [PATCH 2/2] [virtio] Enable and disable PCI device correctly
>
>   src/drivers/bus/pci.c        | 41 +++++++++++++++++++++++++++++++++++------
>   src/drivers/bus/virtio-pci.c | 10 ++++++++++
>   src/drivers/net/virtio-net.c | 30 ++++++++++++++++++++++++++++--
>   src/include/ipxe/pci.h       |  2 ++
>   4 files changed, 75 insertions(+), 8 deletions(-)
>