[ipxe-devel] [PATCH 4/4] [virtio] Add virtio-net 1.0 support

Michael S. Tsirkin mst at redhat.com
Thu Mar 10 14:12:57 UTC 2016


On Wed, Mar 09, 2016 at 07:20:03PM +0100, Ladi Prosek wrote:
> +	/* Enable PCI bus master and reset NIC */
> +	adjust_pci_device ( pci );

At the moment, this enables memory and io unconditionally.  But I think
it should check BAR is assigned before enabling and using it, since
e.g. pci express devices might not have their BARs assigned.

I'm also not sure 64 bit BAR values will work under ipxe -
if not it's preferably to fall back on io or cfg access.

-- 
MST



More information about the ipxe-devel mailing list