[ipxe-devel] [PATCH] [tcp] Send keepalive packets to prevent TCP stalls

[Ladi Prosek]

On Mon, Jun 13, 2016 at 12:27 PM, Ladi Prosek <lprosek at redhat.com> wrote:
> On Mon, Jun 13, 2016 at 11:04 AM, Michael Brown <mcb30 at ipxe.org> wrote:
>> On 13/06/16 08:33, Ladi Prosek wrote:
>>>>
>>>> Could you try out
>>>>
>>>>
>>>> http://git.ipxe.org/people/mcb30/ipxe.git/shortlog/refs/heads/keepalive
>>>>
>>>> and let me know if it has any issues?
>>>
>>>
>>> Thanks! This branch seems to have an unrelated issue, imgfetch fails
>>> with "No space left on device" so I tested your commit on top of
>>> ipxe/master.
>>
>>
>> That's bizarre, since that branch _was_ only a single commit on top of the
>> current ipxe/master.
>
> External heap grows downwards from 4000000 (size 3f00000)
> on the keepalive branch vs.
> External heap grows downwards from 7fef5000 (size 7fdf5000)
> on ipxe/master with the exact same VM with 2 gigs of memory. I'll take
> a closer look.

Turns out I've been building my master with ROM_BANNER_TIMEOUT defined
as 0 so I wasn't dropping into the shell as early as with the other
branch. Seems to be by design, mystery solved :)

Thanks,
Ladi