[ipxe-devel] [PATCH 1/1] [intel] Add PCI device IDs for Intel I218-LM and I218-V

[Thomas Miletich]

On Thu, Jan 28, 2016 at 2:13 PM, Michael Brown <mcb30 at ipxe.org> wrote:
> The error recovery code for the latest possible error in the function will
> always be unreachable with this design pattern.

Thanks for the explanation, that makes sense.

I just noticed it while scrolling by, and it looked like it could have
been by accident at first glance. I'm currently supposed to be doing
other things, so I didn't take the time to check, and figured one
would want to get rid of unreachable code anyway.

Maybe a

/* error handling preparation; intentionally unreachable for now */

would help the uninitiated reader :).

Thomas