[ipxe-devel] [PATCH 1/1] [iscsi] don't close when receiving nop-in

Vishvananda Ishaya Abrams vish.ishaya at oracle.com
Thu Dec 8 18:17:13 UTC 2016


Some iscsi targets send nop-in. Rather than closing the connection when
we receive one, it is more user friendly to log a debug message and
keep the connection open. Eventually, it would be nice if ipxe
supported replying to nop-ins, but we might as well keep the connection
open until the initiator disconnects us.
---
 src/net/tcp/iscsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/net/tcp/iscsi.c b/src/net/tcp/iscsi.c
index d6f8008..e3aee54 100644
--- a/src/net/tcp/iscsi.c
+++ b/src/net/tcp/iscsi.c
@@ -625,7 +625,7 @@ static int iscsi_rx_nop_in ( struct iscsi_session *iscsi,
 	if ( nop_in->ttt != htonl ( ISCSI_TAG_RESERVED ) ) {
 		DBGC ( iscsi, "iSCSI %p received unsupported NOP-In with TTT "
 		       "%08x\n", iscsi, ntohl ( nop_in->ttt ) );
-		return -ENOTSUP_NOP_IN;
+		return 0;
 	}
 
 	return 0;
-- 
2.5.0




More information about the ipxe-devel mailing list