[ipxe-devel] [ipxe] Reverts changes to src/net/udp/tftp.c made in commit 76675365271291beb9d... (#33)

Ben Hildred notifications at github.com
Wed Jan 7 17:33:00 UTC 2015


>  	size_t len;
>  	struct io_buffer *iobuf;
>  	size_t blksize;
>  
> +	/* Strip initial '/' if present. If we were opened via the
> +	* URI interface, then there will be an initial '/', since a
> +	* full tftp:// URI provides no way to specify a non-absolute
> +	* path. However, many TFTP servers (particularly Windows
> +	* TFTP servers) complain about having an initial '/', and it
> +	* violates user expectations to have a '/' silently added to
> +	* the DHCP-specified filename.
> +	*/
> +	path = tftp->uri->path;

how is lines 327 and 340 different from line 326?

I like your comment though.

---
Reply to this email directly or view it on GitHub:
https://github.com/ipxe/ipxe/pull/33/files#r22600760
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ipxe.org/pipermail/ipxe-devel/attachments/20150107/6f04a411/attachment.htm>


More information about the ipxe-devel mailing list