[ipxe-devel] [PATCH] [libprefix] Use correct register for physical address conversion

Daniel Pieczko dpieczko at solarflare.com
Fri Aug 14 15:42:33 UTC 2015

On 14/08/15 16:24, Michael Brown wrote:
> On 12/08/15 11:45, Daniel Pieczko wrote:
>>          /* Convert %ds:esi and %es:edi back to physical addresses */
>>          xorl    %eax, %eax
>> -       movw    %ds, %cx
>> +       movw    %ds, %ax
>>          shll    $4, %eax
>>          addl    %eax, %esi
>>          xorl    %eax, %eax
>> -       movw    %es, %cx
>> +       movw    %es, %ax
>>          shll    $4, %eax
>>          addl    %eax, %edi
> Applied, thanks!
>   http://git.ipxe.org/ipxe.git/commitdiff/abd36b9
> Given that this affects only code compiled with KEEP_IT_REAL (which doesn't work
> anyway), I have to ask: how did you find this?

We aren't using KEEP_IT_REAL if that's what you're wondering!

It was just from code inspection while I was reading various bits of this file.


The information contained in this message is confidential and is intended for the addressee(s) only. If you have received this message in error, please notify the sender immediately and delete the message. Unless you are an addressee (or authorized to receive for an addressee), you may not use, copy or disclose to anyone this message or any information contained in this message. The unauthorized use, disclosure, copying or alteration of this message is strictly prohibited.

More information about the ipxe-devel mailing list