[ipxe-devel] [ipxe] ConnectX3 support from Mellanox Flexboot (#20)

Michael Brown mcb30 at ipxe.org
Wed May 21 09:54:32 BST 2014


On 21/05/14 09:25, ya-mouse wrote:
> Merge FlexBoot's hermon driver code from
> http://www.mellanox.com/downloads/Drivers/PXE/gpxe_3.4.225.tgz to
> support MT27500.

That patch has multiple issues:

- large numbers of whitespace-only changes

- large number of s/Hermon/ConnectX3/ changes

- unclear whether or not the code removes support for older 
ConnectX/ConnectX2 devices

- introduces a disallowed #ifdef FLASH_CONFIGURATION_CAP

- non-volatile settings mechanism is implemented backwards: it should be 
providing a new child settings block providing generic access to the 
non-volatile settings, rather than cherry-picking settings and hacking 
them in to the generic netdevice settings block

- uses printf() instead of DBG()

- introduces ibdev->eth_mac_[lh] for no discernible reason

I stopped reviewing at this point.  There's no way this patch can be 
merged; it fails far too many code quality checks.

Michael


More information about the ipxe-devel mailing list