[ipxe-devel] [PATCH v2 0/3] ipxe/autoboot: Boot only from requested device

[Michael Brown]

On 25/02/14 23:00, Alex Williamson wrote:
> v2:
>   - Tweaked approached based on IRC comments from Michael
>     - Host device location matching in autoboot rather than pci
>     - Use i386/core initialization hook to relay BSS to autoboot
>
> This version actually passes 'make everything' for each step and
> should provide an obvious interface for other paths to specify the
> device location of the autoboot device.  This should support devices
> with multiple netdevs and should be completely compatible if no
> autoboot device is specifed or no matching devices are found.  This
> latter case should retain the ability to deploy iPXE for one device
> in another device ROM, ex. wifi iPXE loaded from wired NIC ROM space.

Applied with some modifications, thanks!

To slightly reduce the code size, I changed the logic so that if an 
autoboot device location is specified then we use only devices matching 
that location (even if no such devices are found).  In the uncommon case 
of a wireless NIC iPXE driver stored on a wired NIC's ROM, users can use 
the "autoboot" command (which isn't affected by this change).  WiFi 
booting will usually require an encryption key to be set, which 
typically requires the use of an embedded script anyway.

I think this probably minimises user surprise in the case of e.g. a 
driver initialisation failure (which could cause devices to be missing 
from iPXE's device list, thus otherwise causing iPXE to attempt to boot 
from all devices even when the user really was wanting to boot from just 
a single device).

Thanks for this!

Michael