[ipxe-devel] [PATCH 1/3] scsi: Improve sense code parsing

[Hannes Reinecke]

On 06/03/2014 03:29 AM, Michael Brown wrote:
> On 30/05/14 08:18, Hannes Reinecke wrote:
>> The SCSI sense code comes in two flavours, 'fixed' and 'descriptor'.
>> Each of which have the interesting portions like additonal sense code
>> etc at different locations.
>> So instead of blindly copying out some bytes we should parse the
>> sense code buffer and make sure to return the correct values.
>
> Pushed a patch with equivalent functionality:
>
>    http://git.ipxe.org/ipxe.git/commitdiff/e047811
>
> Thanks!
>
Hmph.

Sadly, it's not equivalent.
My patch parsed the asc and ascq values, too.
Without it it's pretty much pointless trying to figure out what went 
wrong; the key will be 'check condition', and we won't have any 
means to figure out _which_ condition.
At the same time, the additional length is pretty much pointless.

What was wrong with my original patch?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare at suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)