[ipxe-devel] [PATCH] Fix loading tftp file from pxe bios call

Michael Brown mbrown at fensystems.co.uk
Wed May 15 14:56:40 UTC 2013


On 13/05/13 15:59, Frediano Ziglio wrote:
>  From 1827c48034d2387819629c4b28d7c2910b5d889b Mon Sep 17 00:00:00 2001
> From: Frediano Ziglio<frediano.ziglio at citrix.com>
> Date: Mon, 13 May 2013 15:58:32 +0100
> Subject: [PATCH] Fix loading tftp file from pxe bios call
>
> If filename contained '#' tftp does not load correctly file cause url was not
> quoted correctly.
>
> This patch actually fix two paths in the code that require quoting filename:
> - loading file from dhcp;
> - loading file from PXE calls.

The fact that TFTP doesn't fit neatly into the RFC2396's concept of a 
URI is extremely annoying!

Would it be neater to have net/udp/tftp.c append "#" and uri->fragment 
if uri->fragment is non-NULL?  This would then provide the same 
behaviour for TFTP URIs present in scripts.

Michael



More information about the ipxe-devel mailing list