[ipxe-devel] compile fails with gcc 4.8.0

[Daniel P. Berrange]

On Fri, Jun 07, 2013 at 02:05:54PM +0100, Michael Brown wrote:
> Christian Hesse<list at eworm.de>   on Tue, 2013/04/02 10:35:
> >with gcc 4.8.0 compilation fails:
> >
> >[BUILD] bin/pxe_call.o
> >arch/i386/interface/pxe/pxe_call.c: In function ‘pxe_start_nbp’:
> >arch/i386/interface/pxe/pxe_call.c:284:1: error: bp cannot be used in asm here
> 
> The icky workaround for this is now pushed:
> 
>   http://git.ipxe.org/ipxe.git/commitdiff/238050d

This doesn't look right:

-                                          "addw $4, %%sp\n\t" )
+                                          "popl %%ebp\n\t" /* discard */
+                                          "popl %%ebp\n\t" /* gcc bug */ )


In the original patch it was

-                                          "addw $4, %%sp\n\t" )
+                                          "addw $4, %%sp\n\t"
+                                          "popl %%ebp\n\t" )

You've accidentally transposed the 'addw' into a second 'popl'.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|