[ipxe-devel] [PATCH] Export iPXE download protocols to chain loaded EFI binaries

[Jarrod Johnson]

In my tests, the patch with better error handling seems to work without a
problem.

My modified elilo and esxi5 bootloader both made it through boot with
command line arguments intact and everything.

Thanks.
On Mon, Feb 13, 2012 at 8:12 AM, Michael Brown <mbrown at fensystems.co.uk>wrote:

> On Saturday 11 Feb 2012 20:41:36 Jarrod Johnson wrote:
> > In the same way iPXE exports its capabilities under BIOS in a way that
> > pxelinux.0 exploits to get better protocols than tftp, export
> capabilities
> > as a UEFI protocol so that other efi binaries may use it instead of tftp.
> > Can be used together with a patch submitted to elilo for one example:
> > http://comments.gmane.org/gmane.comp.boot-loaders.elilo.general/147
> >
> >
> https://git.ipxe.org/vendor/xcat/ipxe.git/commitdiff/d748ebf72206dcde1379b0
> > 63fd9b533f7572caa5
> >
> https://git.ipxe.org/vendor/xcat/ipxe.git/commitdiff/e7b41890bc67350a9f5bc
> > f7291ec859fa2174e26
> >
> https://git.ipxe.org/vendor/xcat/ipxe.git/commitdiff/45a51f99fd51b231a388b
> > 1db00dfc4b18a5e9e4f
> >
> https://git.ipxe.org/vendor/xcat/ipxe.git/commitdiff/a84739023c391fa4d5e3b
> > 65a487834bf92552895
> >
> https://git.ipxe.org/vendor/xcat/ipxe.git/commitdiff/23aea6c209965546c3956
> > 9a770823eabf1358a71
>
> I've merged these into a single patch (not yet merged):
>
>  http://git.ipxe.org/people/mcb30/ipxe.git/commitdiff/1730726
>
> This is produced by taking your commits, converting initial spaces to tabs
> where applicable, and changing "gPXE" to "iPXE" where applicable.
>
> I also tidied up what looked like some dubious error handling in
> efi_image.c:
> errors were being ignored, and nothing ever freed the memory allocated by
> efi_image_make_cmdline().  I've put in what I think should be correct
> code, but
> I haven't tested it in any way.
>
> Please let me know if you think this modified patch is OK to merge.
>
> Thanks,
>
> Michael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ipxe.org/pipermail/ipxe-devel/attachments/20120213/eea3835d/attachment.htm>