[ipxe-devel] [gPXE-devel] [PATCH][forcedeth] Exit poll() as early as possible if no work to do

[Michael Brown]

On Thursday 11 Nov 2010 21:51:09 Thomas Miletich wrote:
> > Could you try starting iPXE+your patch with the link down (e.g. cable
> > unplugged), open the net device, plug in the cable, and see if ifstat
> > reports link-up?
>
> <snip>
>
> So I opened the interface('ifopen net0') and plugged the cable in.
> ifstats shows the link as up as soon as I plug the cable in, even with
> the patch applied.
> 
> Please keep in mind that this card is listed as 'nforce2', the 2nd PCI
> ID in the linux and [g|i]PXE drivers, which suggests it's one of the
> very first chip revisions. I assume this card variant hasn't gotten
> much, if any, testing since the driver update in July. This could very
> well only apply to a few card variants.

Thanks for testing.  Have applied as

  http://git.ipxe.org/ipxe.git/commit/f122515

(for which I accidentally screwed up the author information, and so applied an 
empty commit

  http://git.ipxe.org/ipxe.git/commitdiff/06dbe70

with you correctly listed as the author).

If this commit does cause a problem on some other forcedeth cards in future, 
it should be easy to find with a git bisect.

Michael