[ipxe-devel] [PATCH] [igbvf] Add igbvf driver
Alex Williamson
alex.williamson at redhat.com
Thu Dec 16 04:08:26 UTC 2010
On Thu, 2010-12-16 at 04:06 +0000, Michael Brown wrote:
> On Thursday 16 Dec 2010 03:46:56 Alex Williamson wrote:
> > > igbvf_vf.c does not build:
> > >
> > > drivers/net/igbvf/igbvf_vf.c: In function ‘igbvf_update_mc_addr_list_vf’:
> > > drivers/net/igbvf/igbvf_vf.c:289: error: ‘msgbuf’ may be used
> > > uninitialized in this function
> > > drivers/net/igbvf/igbvf_vf.c:270: note: ‘msgbuf’ was declared here
> > > make: *** [bin/igbvf_vf.o] Error 1
> >
> > Hmm, looks like a bug in the upstream driver. A tiny code rearrangement
> > should fix it. I'll send a new version. BTW, I'm not able to duplicate
> > the build error, so please let me know if you're doing anything special
> > to check for errors. Thanks,
>
> There's nothing special I'm doing; some gcc versions just seem to pick up
> uninitialised-variable errors better than others. (Interestingly, gcc3 often
> seems to pick up errors that gcc4 doesn't.)
>
> Version 2 of the patch is applied:
>
> http://git.ipxe.org/ipxe.git/commit/c080de1
Great, thanks :)
Alex
More information about the ipxe-devel
mailing list