[ipxe-devel] [PATCH] [igbvf] Add igbvf driver

Alex Williamson alex.williamson at redhat.com
Thu Dec 16 03:46:56 UTC 2010


On Wed, 2010-12-15 at 16:51 +0000, Michael Brown wrote:
> On Friday 10 Dec 2010 20:57:21 Alex Williamson wrote:
> > Driver for Intel 82576 based virtual functions, based on Intel source
> > code available at:
> > 
> >     http://sourceforge.net/projects/e1000  (igbvf-1.0.7)
> > 
> > Based on initial port from Eric Keller <ekeller at princeton.edu>.
> > 
> > Signed-off-by: Alex Williamson <alex.williamson at redhat.com>
> 
> Thanks.  There are some issues with the patch:
> 
> drivers/net/igbvf/Makefile is a Linux makefile fragment and should not be 
> present.

Dropped

> igbvf_vf.c does not build:
> 
> drivers/net/igbvf/igbvf_vf.c: In function ‘igbvf_update_mc_addr_list_vf’:
> drivers/net/igbvf/igbvf_vf.c:289: error: ‘msgbuf’ may be used uninitialized in 
> this function
> drivers/net/igbvf/igbvf_vf.c:270: note: ‘msgbuf’ was declared here
> make: *** [bin/igbvf_vf.o] Error 1

Hmm, looks like a bug in the upstream driver.  A tiny code rearrangement
should fix it.  I'll send a new version.  BTW, I'm not able to duplicate
the build error, so please let me know if you're doing anything special
to check for errors.  Thanks,

Alex




More information about the ipxe-devel mailing list