<p></p>
<blockquote>
<p dir="auto">Time needed to verify correctness of this patch is one possible issue, maybe this could be lessened with proper tests, or at least something that can be used to verify the issue. But this is critical code that and we must be absolute certain does not introduce any new security issues.</p>
</blockquote>
<p dir="auto">Note that there's also <a href="https://github.com/chschenk/ipxe/tree/feature/tls_fragmentation_buildoption">https://github.com/chschenk/ipxe/tree/feature/tls_fragmentation_buildoption</a> which add's a build option. By making this code optional and disable that build option by default it at least wouldn't break anything. Regarding security concerns: granted. But we're talking about ~50 lines of code here.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/ipxe/ipxe/pull/116#issuecomment-1096766788">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAFNGVGLQEEDKQQE3RQXCYLVEV6QTANCNFSM4OF2NB2A">unsubscribe</a>.<br />You are receiving this because you commented.<img src="https://github.com/notifications/beacon/AAFNGVANV4QA332XXWNZIK3VEV6QTA5CNFSM4OF2NB2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIFPVKRA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><ipxe/ipxe/pull/116/c1096766788</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/ipxe/ipxe/pull/116#issuecomment-1096766788",
"url": "https://github.com/ipxe/ipxe/pull/116#issuecomment-1096766788",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>