<p></p>
<p><b>@mcb30</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/ipxe/ipxe/pull/42#discussion_r567156919">src/arch/i386/Makefile.pcbios</a>:</p>
<pre style='color:#555'>> @@ -58,19 +58,19 @@ NON_AUTO_MEDIA   += iso
 %iso:  %lkrn util/geniso
        $(QM)$(ECHO) "  [GENISO] $@"
        $(Q)ISOLINUX_BIN=$(ISOLINUX_BIN) LDLINUX_C32=$(LDLINUX_C32) \
-           VERSION="$(VERSION)" bash util/geniso -o $@ $<
+           VERSION="$(VERSION)" bash -e util/geniso -o $@ $<
</pre>
<p><code>util/geniso</code> and <code>util/gensdsk</code> have been replaced with <code>util/genfsimg</code> which already includes a <code>set -e</code> within the script itself.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you commented.<br />Reply to this email directly, <a href="https://github.com/ipxe/ipxe/pull/42#pullrequestreview-579694405">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAFNGVBFUY77EBIYEY4FO2DS4ND2LANCNFSM4BVVV5MA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAFNGVANNC6JJHYFOLPM4XLS4ND2LA5CNFSM4BVVV5MKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEKGW6RI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/ipxe/ipxe/pull/42#pullrequestreview-579694405",
"url": "https://github.com/ipxe/ipxe/pull/42#pullrequestreview-579694405",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>