<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, May 3, 2020, 16:29 Geert Stappers <<a href="mailto:stappers@stappers.nl">stappers@stappers.nl</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Sun, May 03, 2020 at 12:18:26PM +0900, Christian Nilsson wrote:<br>
> What if there is any local non commited changes, or config file changes, or<br>
> embedded script changes. The checksum over linked solves the hash, but is<br>
> it actually correct to use git as a source for BUILD_TIMESTAMP when there<br>
> is local changes?<br>
<br>
I see the warning, but I don't see the problem.<br>
In case that doesn't answer the "What if question",<br>
please elaborate what the hidden danger is.<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">No, I get it: a pristine HEAD and a dirty HEAD don't deserve the same source date epoch. There's some ways to disambiguate these with `git stash`, but this is starting to get complicated. It could become an ugly `$(shell ...)` in the Makefile.housekeeping, or I could put it in a helper shell script. What's the right decision for ipxe?</div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
</blockquote></div></div></div>