<p><b>@toreanderson</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/ipxe/ipxe/pull/84#discussion_r354522580">src/config/general.h</a>:</p>
<pre style='color:#555'>> @@ -35,7 +35,7 @@ FILE_LICENCE ( GPL2_OR_LATER_OR_UBDL );
  */
 
 #define        NET_PROTO_IPV4          /* IPv4 protocol */
-#undef NET_PROTO_IPV6          /* IPv6 protocol */
+//#define      NET_PROTO_IPV6          /* IPv6 protocol */
</pre>
<p>IIRC because this file (<code>src/config/general.h</code>) is included <em><strong>after</strong></em> <code>src/config/defaults/efi.h</code>. Thus, if the <code>#undef NET_PROTO_IPV6</code> is left unchanged here, it ends up overrides the newly added <code>#define NET_PROTO_IPV6</code> from <code>src/config/defaults/efi.h</code>.</p>
<p>Changing it to <code>//#define</code> follows the <code>IMAGE_EFI</code> example:<br>
<a href="https://github.com/ipxe/ipxe/blob/7656bf6a333a63e1da3483cf0b2a814252f56161/src/config/general.h#L113">https://github.com/ipxe/ipxe/blob/7656bf6a333a63e1da3483cf0b2a814252f56161/src/config/general.h#L113</a><br>
<a href="https://github.com/ipxe/ipxe/blob/7656bf6a333a63e1da3483cf0b2a814252f56161/src/config/defaults/efi.h#L30">https://github.com/ipxe/ipxe/blob/7656bf6a333a63e1da3483cf0b2a814252f56161/src/config/defaults/efi.h#L30</a></p>
<p>This logic accomplishes making the define in question default enabled for the EFI platform, while at the same time leaving it default disabled for all other platforms (unless explicitly disabled for some other specific platforms too).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/ipxe/ipxe/pull/84?email_source=notifications&email_token=AAFNGVB5XZQ4S4ELQV2UNPTQXFNRRA5CNFSM4GFAQL52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOFCI2A#discussion_r354522580">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAFNGVFU6MBDDOGFCVVKQHDQXFNRRANCNFSM4GFAQL5Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAFNGVGBXFTXUO5OSZGAY2DQXFNRRA5CNFSM4GFAQL52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOFCI2A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/ipxe/ipxe/pull/84?email_source=notifications\u0026email_token=AAFNGVB5XZQ4S4ELQV2UNPTQXFNRRA5CNFSM4GFAQL52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOFCI2A#discussion_r354522580",
"url": "https://github.com/ipxe/ipxe/pull/84?email_source=notifications\u0026email_token=AAFNGVB5XZQ4S4ELQV2UNPTQXFNRRA5CNFSM4GFAQL52YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCOFCI2A#discussion_r354522580",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>