<p><b>@philmd</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/ipxe/ipxe/pull/96#discussion_r331952072">src/hci/commands/ifmgmt_cmd.c</a>:</p>
<pre style='color:#555'>> @@ -202,6 +204,9 @@ static struct option_descriptor ifconf_opts[] = {
        OPTION_DESC ( "configurator", 'c', required_argument,
                      struct ifconf_options, configurator,
                      parse_netdev_configurator ),
+       OPTION_DESC ( "timeout", 't', required_argument,
</pre>
<p>I'm tempted to use <code>timeout_ms</code> to explicit the unit.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/ipxe/ipxe/pull/96?email_source=notifications&email_token=AAFNGVBXVZHMKBUYGTWC5TDQNMHCNA5CNFSM4IYWU5JKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHB3XQY#pullrequestreview-298040259">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAFNGVG4REAZ4IJFC6VP62LQNMHCNANCNFSM4IYWU5JA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAFNGVEORHSO5MVHIYSF6P3QNMHCNA5CNFSM4IYWU5JKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHB3XQY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/ipxe/ipxe/pull/96?email_source=notifications\u0026email_token=AAFNGVBXVZHMKBUYGTWC5TDQNMHCNA5CNFSM4IYWU5JKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHB3XQY#pullrequestreview-298040259",
"url": "https://github.com/ipxe/ipxe/pull/96?email_source=notifications\u0026email_token=AAFNGVBXVZHMKBUYGTWC5TDQNMHCNA5CNFSM4IYWU5JKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHB3XQY#pullrequestreview-298040259",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>