<p>This change will only be compiled into the resulting binary when HTTPS support is switched on via config/general.h. By default it's off.</p>
<p>Here's a size comparison of the ipxe binaries for plain (no HTTPS support), https-old (with the memcpy()), and https-fixed (with the above change):</p>
<pre><code>plain/:
 328192   ipxe.dsk
1048576   ipxe.iso
 329238   ipxe.pxe
1409024   ipxe.usb

https-old/:
 339968  ipxe.dsk
1048576  ipxe.iso
 341181  ipxe.pxe
1409024  ipxe.usb

https-fixed/:
 340480  ipxe.dsk
1048576  ipxe.iso
 341105  ipxe.pxe
1409024  ipxe.usb
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/ipxe/ipxe/pull/90#issuecomment-464144536">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AArTVL480yPpOR6qTxJklgaTND9bIBFDks5vNvdAgaJpZM4a-EdD">mute the thread</a>.<img src="https://github.com/notifications/beacon/AArTVGtcPgL195OKty-d6s6rpUIeJxJzks5vNvdAgaJpZM4a-EdD.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/ipxe/ipxe","title":"ipxe/ipxe","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/ipxe/ipxe"}},"updates":{"snippets":[{"icon":"PERSON","message":"@t-lo in #90: This change will only be compiled into the resulting binary when HTTPS support is switched on via config/general.h. By default it's off.\r\n\r\nHere's a size comparison of the ipxe binaries for plain (no HTTPS support), https-old (with the memcpy()), and https-fixed (with the above change):\r\n```\r\nplain/:\r\n 328192   ipxe.dsk\r\n1048576   ipxe.iso\r\n 329238   ipxe.pxe\r\n1409024   ipxe.usb\r\n\r\nhttps-old/:\r\n 339968  ipxe.dsk\r\n1048576  ipxe.iso\r\n 341181  ipxe.pxe\r\n1409024  ipxe.usb\r\n\r\nhttps-fixed/:\r\n 340480  ipxe.dsk\r\n1048576  ipxe.iso\r\n 341105  ipxe.pxe\r\n1409024  ipxe.usb\r\n```"}],"action":{"name":"View Pull Request","url":"https://github.com/ipxe/ipxe/pull/90#issuecomment-464144536"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/ipxe/ipxe/pull/90#issuecomment-464144536",
"url": "https://github.com/ipxe/ipxe/pull/90#issuecomment-464144536",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>