<p>FWIW:  I think it would have helped if it were several commits.</p>
<p>The four year old commit does much more then</p>
<pre><code>       if  ( uuid.canonical.a == 0x4c4c4544 ) {
                uuid_mangle ( &uuid );
       }
</code></pre>
<p>What the extra changes are, is now lost in the large commit ...</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/ipxe/ipxe/pull/30#issuecomment-461751508">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AArTVGcDMRi-Z_i4Ntq5Dtgay7HZR2dEks5vLUtGgaJpZM4Cpa1W">mute the thread</a>.<img src="https://github.com/notifications/beacon/AArTVNYmH24M5C9s1YqNn7Lh3aTOO5llks5vLUtGgaJpZM4Cpa1W.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/ipxe/ipxe","title":"ipxe/ipxe","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/ipxe/ipxe"}},"updates":{"snippets":[{"icon":"PERSON","message":"@stappersg in #30: FWIW:  I think it would have helped if it were several commits.\r\n\r\nThe four year old commit does much more then\r\n```\r\n       if  ( uuid.canonical.a == 0x4c4c4544 ) {\r\n                uuid_mangle ( \u0026uuid );\r\n       }\r\n```\r\nWhat the extra changes are, is now lost in the large commit ..."}],"action":{"name":"View Pull Request","url":"https://github.com/ipxe/ipxe/pull/30#issuecomment-461751508"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/ipxe/ipxe/pull/30#issuecomment-461751508",
"url": "https://github.com/ipxe/ipxe/pull/30#issuecomment-461751508",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>