<p>The idea of the patch was that hashing all relevant inputs still gives build-ids that are different when they should.<br>
I was trying to get xen to build reproducibly, but just noticed that it does not even run this code-path for its etherboot. So I cannot test this.<br>
Feel free to close.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/ipxe/ipxe/pull/82#issuecomment-432691502">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AArTVNBMCOZ47WlNsx_fecmtbtIr1bA9ks5uoH8jgaJpZM4X3UjH">mute the thread</a>.<img src="https://github.com/notifications/beacon/AArTVMO2jTLTKpG7BOMq8pndxMUs85Ccks5uoH8jgaJpZM4X3UjH.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/ipxe/ipxe","title":"ipxe/ipxe","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/ipxe/ipxe"}},"updates":{"snippets":[{"icon":"PERSON","message":"@bmwiedemann in #82: The idea of the patch was that hashing all relevant inputs still gives build-ids that are different when they should.\r\nI was trying to get xen to build reproducibly, but just noticed that it does not even run this code-path for its etherboot. So I cannot test this.\r\nFeel free to close."}],"action":{"name":"View Pull Request","url":"https://github.com/ipxe/ipxe/pull/82#issuecomment-432691502"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/ipxe/ipxe/pull/82#issuecomment-432691502",
"url": "https://github.com/ipxe/ipxe/pull/82#issuecomment-432691502",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [ipxe/ipxe] [build] Do not use random build_ids (#82)",
"sections": [
{
"text": "",
"activityTitle": "**Bernhard M. Wiedemann**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@bmwiedemann",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"ipxe/ipxe\",\n\"issueId\": 82,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"ipxe/ipxe\",\n\"pullRequestId\": 82\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/ipxe/ipxe/pull/82#issuecomment-432691502"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 400378055\n}"
}
],
"themeColor": "26292E"
}
]</script>