<blockquote>
<p>You might also want to read about preferred git commit message style:<br>
<a href="http://ipxe.org/admin#commit_log_messages" rel="nofollow">http://ipxe.org/admin#commit_log_messages</a></p>
</blockquote>
<p>Could you be more specific? Is there something wrong with this besides missing <code>Signed-off-by:</code>?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/ipxe/ipxe/pull/79#issuecomment-426401583">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AArTVO7newd9Q9knCMxN81aVm3XOE12mks5ug79NgaJpZM4XEtB0">mute the thread</a>.<img src="https://github.com/notifications/beacon/AArTVF1x8ru-DZKI83gFLZSahF4wS_sFks5ug79NgaJpZM4XEtB0.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/ipxe/ipxe","title":"ipxe/ipxe","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/ipxe/ipxe"}},"updates":{"snippets":[{"icon":"PERSON","message":"@lasalvavida in #79: \u003e You might also want to read about preferred git commit message style:\r\nhttp://ipxe.org/admin#commit_log_messages\r\n\r\nCould you be more specific? Is there something wrong with this besides missing `Signed-off-by:`?"}],"action":{"name":"View Pull Request","url":"https://github.com/ipxe/ipxe/pull/79#issuecomment-426401583"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/ipxe/ipxe/pull/79#issuecomment-426401583",
"url": "https://github.com/ipxe/ipxe/pull/79#issuecomment-426401583",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [ipxe/ipxe] [intelx] Added PCI_ROM entry for Intel x553/x557-AT and x553 (SFP+) NICs (#79)",
"sections": [
{
"text": "",
"activityTitle": "**Rob Taglang**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@lasalvavida",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"ipxe/ipxe\",\n\"issueId\": 79,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"ipxe/ipxe\",\n\"pullRequestId\": 79\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/ipxe/ipxe/pull/79#issuecomment-426401583"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 387108980\n}"
}
],
"themeColor": "26292E"
}
]</script>