<html><body><html><head><meta name="viewport" content="width=device-width" /><meta http-equiv="Content-Type" content="text/vnd.ui.insecure+html;charset=utf-8" /></head><body style="overflow-wrap:break-word; word-break: break-word;"><div class="mail_android_message" style="line-height: 1; padding: 0.5em">Thanks for reviewing.<br>
<br>
Is there also an architecture specific bin/error target?<br>
<br>
Maybe we need some architecture specific #define for the prefix.<br>
<br>
Regards<br>
<br>
Heinrich<br>
</div><div class="mail_android_quote" style="line-height: 1; padding: 0.3em">Am 26.08.18, 23:47, Michael Brown <mcb30@ipxe.org> schrieb:<blockquote class="gmail_quote" style="margin: 0.8ex 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
On 26/08/18 11:45, Heinrich Schuchardt wrote:<br />
> diff --git a/src/include/errno.h b/src/include/errno.h<br />
> index e80bf9ca..0294a990 100644<br />
> --- a/src/include/errno.h<br />
> +++ b/src/include/errno.h<br />
> @@ -262,10 +262,10 @@ static inline void eplatform_discard ( int dummy __unused, ... ) {}<br />
> ".align 8\n\t" \<br />
> "\n1:\n\t" \<br />
> ".long ( 4f - 1b )\n\t" \<br />
> - ".long %a0\n\t" \<br />
> + ".long %0\n\t" \<br />
> ".long ( 2f - 1b )\n\t" \<br />
> ".long ( 3f - 1b )\n\t" \<br />
> - ".long %a1\n\t" \<br />
> + ".long %1\n\t" \<br />
> "\n2:\t.asciz \"" __einfo_desc ( einfo ) "\"\n\t" \<br />
> "\n3:\t.asciz \"" __FILE__ "\"\n\t" \<br />
> ".align 8\n\t" \<br />
<br />
This patch results in an incorrect assembler expression for the standard <br />
x86 build, e.g.<br />
<br />
.long $1216<br />
<br />
instead of the needed<br />
<br />
.long 1216<br />
<br />
You can observe the effects using "make bin/errors" and examining the <br />
resulting file. With your patch, all error numbers and line numbers are <br />
zero.<br />
<br />
I'm happy to ditch ARM gcc 4.8 support if it makes it cleaner to support <br />
current versions of gcc, but the patch must still work for the x86 build.<br />
<br />
Michael<br />
</blockquote></div></body></html></body></html>