<p><b>@multun</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/ipxe/ipxe/pull/67#discussion_r185138123">src/net/ipv4.c</a>:</p>
<pre style='color:#555'>> +            sprintf(buf, "255.255.%d.0", n_octet);
+               addr_len = 3;
+       } else if (cidr > 8) {
+               sprintf(buf, "255.%d.0.0", n_octet);
+               addr_len = 2;
+       } else if (cidr > 0) {
+               sprintf(buf, "%d.0.0.0", n_octet);
+               addr_len = 1;
+       } else if (cidr == 0) {
+               sprintf(buf, "0.0.0.0");
+               addr_len = 0;
+       } else {
+               DBGC(cidr, "Unknown netmask descriptor /%d.\n", cidr);
+       }
+
+       return addr_len;
</pre>
<p>why don't you return <code>cidr / 8</code> ?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/ipxe/ipxe/pull/67#pullrequestreview-116469984">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AArTVEUvRiTvr4NakHzVP1mvXJL62-8tks5tt544gaJpZM4Ra3t0">mute the thread</a>.<img src="https://github.com/notifications/beacon/AArTVLH9190aUXuG_Iolc-szhSuamWvkks5tt544gaJpZM4Ra3t0.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/ipxe/ipxe/pull/67#pullrequestreview-116469984"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/ipxe/ipxe","title":"ipxe/ipxe","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/ipxe/ipxe"}},"updates":{"snippets":[{"icon":"PERSON","message":"@multun commented on #67"}],"action":{"name":"View Pull Request","url":"https://github.com/ipxe/ipxe/pull/67#pullrequestreview-116469984"}}}</script>