<p><b>@multun</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/ipxe/ipxe/pull/67#discussion_r185139890">src/net/ipv4.c</a>:</p>
<pre style='color:#555'>> @@ -890,9 +921,51 @@ static int ipv4_settings ( int ( * apply ) ( struct net_device *netdev,
                /* Get default gateway, if present */
                fetch_ipv4_setting ( settings, &gateway_setting, &gateway );
 
-               /* Apply settings */
-               if ( ( rc = apply ( netdev, address, netmask, gateway ) ) != 0 )
-                       return rc;
+               /* Configure route (-s) */
+               uint8_t * raw_data = netdev->static_routes;
+               uint8_t option_len = netdev->static_routes_len;
+
+               /* Check if static routes available
+                * The minimum length for DHCP option 121 is 5 bytes */
+               if ( option_len >= 5 ) {
+                       char buf[16];
+                       uint8_t uaddr[4];
+                       uint8_t i = 0, j, addr_octets_len;
</pre>
<p>declaring multiple variables on a single lines usually is bad style.<br>
the only places you may find it in ipxe is within code ported from linux.</p>
<p>j also is reused multiple times eventhough it could be a different variable every single time.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/ipxe/ipxe/pull/67#pullrequestreview-116472012">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AArTVIYSwgY3s-GEWjzF-xZdb9uKFemFks5tt6D-gaJpZM4Ra3t0">mute the thread</a>.<img src="https://github.com/notifications/beacon/AArTVNQff0-O7t4UI0p9loRzEOvnK6G9ks5tt6D-gaJpZM4Ra3t0.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/ipxe/ipxe/pull/67#pullrequestreview-116472012"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/ipxe/ipxe","title":"ipxe/ipxe","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/ipxe/ipxe"}},"updates":{"snippets":[{"icon":"PERSON","message":"@multun commented on #67"}],"action":{"name":"View Pull Request","url":"https://github.com/ipxe/ipxe/pull/67#pullrequestreview-116472012"}}}</script>