<p><b>@multun</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/ipxe/ipxe/pull/67#discussion_r185138768">src/util/elf2efi.c</a>:</p>
<pre style='color:#555'>> @@ -635,6 +635,7 @@ static void process_reloc ( struct elf_file *elf, const Elf_Shdr *shdr,
                case ELF_MREL ( EM_ARM, R_ARM_THM_JUMP24 ) :
                case ELF_MREL ( EM_ARM, R_ARM_V4BX ):
                case ELF_MREL ( EM_X86_64, R_X86_64_PC32 ) :
+               case ELF_MREL ( EM_X86_64, R_X86_64_PLT32 ) :
</pre>
<p>it's not related is it ? why would PLT calls be emitted anyway ?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/ipxe/ipxe/pull/67#pullrequestreview-116470701">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AArTVB1Yy9L2lPJSZO9nXUq-T_khHpd6ks5tt58xgaJpZM4Ra3t0">mute the thread</a>.<img src="https://github.com/notifications/beacon/AArTVLGlmIywtC9WEMAHBtR-Czcd7yYXks5tt58xgaJpZM4Ra3t0.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/ipxe/ipxe/pull/67#pullrequestreview-116470701"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/ipxe/ipxe","title":"ipxe/ipxe","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/ipxe/ipxe"}},"updates":{"snippets":[{"icon":"PERSON","message":"@multun commented on #67"}],"action":{"name":"View Pull Request","url":"https://github.com/ipxe/ipxe/pull/67#pullrequestreview-116470701"}}}</script>