<p><b>@multun</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/ipxe/ipxe/pull/67#discussion_r185138989">src/net/ipv4.c</a>:</p>
<pre style='color:#555'>> +                    /* Extract routes and add them to routing table */
+                       while ( i < option_len ) {
+                               uint8_t c = raw_data[i];
+                               i++;
+
+                               /* Netmask */
+                               addr_octets_len = cidr_to_mask ( c, buf );
+                               inet_aton( buf, &netmask );
+
+                               /* Address */
+                               memset ( uaddr, 0, 4 * sizeof ( uint8_t ) );
+                               for ( j = 0; j < addr_octets_len; j++ )
+                                       uaddr[j] = raw_data[i + j];
+
+                               sprintf( buf, "%d.%d.%d.%d", uaddr[0], uaddr[1], uaddr[2], uaddr[3] );
+                               inet_aton( buf, &address );
</pre>
<p>why don't you fill out the in_addr directly, using an union for example ?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/ipxe/ipxe/pull/67#pullrequestreview-116470963">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AArTVEEMr4127VyGNVLhGAXS7dOkn_T1ks5tt5-LgaJpZM4Ra3t0">mute the thread</a>.<img src="https://github.com/notifications/beacon/AArTVGgF9lBoOkSiT5fZhihQVcIag8_gks5tt5-LgaJpZM4Ra3t0.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/ipxe/ipxe/pull/67#pullrequestreview-116470963"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/ipxe/ipxe","title":"ipxe/ipxe","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/ipxe/ipxe"}},"updates":{"snippets":[{"icon":"PERSON","message":"@multun commented on #67"}],"action":{"name":"View Pull Request","url":"https://github.com/ipxe/ipxe/pull/67#pullrequestreview-116470963"}}}</script>