<p>HI Michael,</p>
<p>Thanks for reviewing my commit :)</p>
<ol>
<li>
<p>It doesn't solve any problem, but I see 2 purposes. First, if a table is corrupted we shouldn't use the table (that may prevent big problems). Second, (and why I implemented the check) when manipulating ACPI tables it's good to know that the tables are 'probably' not corrupted. For example, I'm working with MADT in ipxe, but I had to debug. So first thing I did was checking the checksum.</p>
</li>
<li>
<p>Debug message fixed.</p>
</li>
<li>
<p>Nice, I didn't think the compiler would optimize the copy_from_user() calls. Done</p>
</li>
</ol>
<p>3a. Good idea, so it's done</p>
<p>Thanks,</p>
<p>Laurent</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you commented.<br />Reply to this email directly, <a href="https://github.com/ipxe/ipxe/pull/65#issuecomment-318678324">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AArTVHDj2h3pYQ8KeJjqLWo1oW71X5Oiks5sSfmSgaJpZM4OldqA">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AArTVPsAYUcViuHTqL6yDZlrTwBLaeqVks5sSfmSgaJpZM4OldqA.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/ipxe/ipxe/pull/65#issuecomment-318678324"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/ipxe/ipxe","title":"ipxe/ipxe","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/ipxe/ipxe"}},"updates":{"snippets":[{"icon":"PERSON","message":"@gourvy in #65: HI Michael,\r\n\r\nThanks for reviewing my commit :)\r\n\r\n1. It doesn't solve any problem, but I see 2 purposes. First, if a table is corrupted we shouldn't use the table (that may prevent big problems). Second, (and why I implemented the check) when manipulating ACPI tables it's good to know that the tables are 'probably' not corrupted. For example, I'm working with MADT in ipxe, but I had to debug. So first thing I did was checking the checksum.\r\n\r\n2. Debug message fixed.\r\n\r\n3. Nice, I didn't think the compiler would optimize the copy_from_user() calls. Done\r\n\r\n3a. Good idea, so it's done\r\n\r\nThanks,\r\n\r\nLaurent\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/ipxe/ipxe/pull/65#issuecomment-318678324"}}}</script>