<p>It needs a substantial cleanup before being mergeable.  Also, rather than argue over which digest algorithm commands should exist, we should be able to use whichever digests are compiled in (which is controlled by config/crypto.h); this will require either a command syntax such as "digest sha256 <a href="" target="_blank"><img style="max-width:100%;"></a>" with digests collected via the linker table mechanism, or per-digest files linked in as necessary (as used by e.g. crypto/mishmash/rsa_sha256.c).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/ipxe/ipxe/pull/57#issuecomment-290369961">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AArTVLTXB9IVem45mAzoBF552aInLblDks5rq4P3gaJpZM4KSoxO">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AArTVBvD8FxPTJmnuRWkxoIDB7StUb_mks5rq4P3gaJpZM4KSoxO.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/ipxe/ipxe/pull/57#issuecomment-290369961"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/ipxe/ipxe","title":"ipxe/ipxe","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/ipxe/ipxe"}},"updates":{"snippets":[{"icon":"PERSON","message":"@mcb30 in #57: It needs a substantial cleanup before being mergeable.  Also, rather than argue over which digest algorithm commands should exist, we should be able to use whichever digests are compiled in (which is controlled by config/crypto.h); this will require either a command syntax such as \"digest sha256 \u003cimage\u003e\" with digests collected via the linker table mechanism, or per-digest files linked in as necessary (as used by e.g. crypto/mishmash/rsa_sha256.c)."}],"action":{"name":"View Pull Request","url":"https://github.com/ipxe/ipxe/pull/57#issuecomment-290369961"}}}</script>