Ok, patch for review at:<div><a href="https://xcat.svn.sourceforge.net/svnroot/xcat/xcat-dep/trunk/xnba/ipxe-registersan.patch">https://xcat.svn.sourceforge.net/svnroot/xcat/xcat-dep/trunk/xnba/ipxe-registersan.patch</a></div>
<div><br></div><div><a href="https://xcat.svn.sourceforge.net/svnroot/xcat/xcat-dep/trunk/xnba/ipxe-registersan.patch"></a>This patch was 'good enough' for my purposes.</div><div><br></div><div>It does request another 256 byte set of chars.</div>
<div><br></div><div>There is an amount of code duplication between 'boot_root_path' and 'reg_root_path' in this approach.</div><div><br></div><div>One way to fix both would be to have the hook & describe before trying to boot anything, then either filename or san_boot, so that both have a common hook&describe. I was cautious and also was unsure if we should consider hook, parse, and describe errors as not particularly fatal in the boot filename whereas in the sanboot case it would warrant more pessimistic output...</div>
<div><br></div><div>Thankfully, the hook/describe/boot is nice and segregated now, so a patch like this is trivial.</div><div><br></div><div><br><div class="gmail_quote">On Thu, Nov 11, 2010 at 6:51 PM, Michael Brown <span dir="ltr"><<a href="mailto:mbrown@fensystems.co.uk">mbrown@fensystems.co.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">On Thursday 11 Nov 2010 22:27:03 <a href="mailto:jarrod.b.johnson@gmail.com">jarrod.b.johnson@gmail.com</a> wrote:<br>
> I do, will post tomorrow for review. It is conservative and may be<br>
<div class="im">> better done through refactoring boot_root_path in half...<br>
><br>
</div>> One objection I could see. IIRC, freebsd is a case where the pxe<br>
<div class="im">> payload will interpret root_path for nfs root and ipxe trying to interpret<br>
> could be odd..<br>
<br>
</div>I'm assuming that we should handle an existent but incomprehensible root-path<br>
(e.g. an NFS root-path) by noisily failing to hook the SAN device and then<br>
continuing with the normal filename boot.<br>
<font color="#888888"><br>
Michael<br>
</font></blockquote></div><br></div>