[ipxe-devel] [PATCH 2/2] [http] Support booting images larger than 2GB over http on 32-bit builds

[Johannes Thoma]

Hello Michael,

Sorry for the late answer, I was busy fixing something in the
WinDRBD network stack the last two weeks.

Am 23.01.19 um 12:19 schrieb Michael Brown:
> Thanks.  I will review this in more detail later, but there's one initial comment: is it necessary to widen the various length parameters beyond size_t?  It's meaningful to request a 64-bit file offset on a 32-bit system, but there's no way we can ever transfer more than a 4GB length in a single request on a 32-bit system since there wouldn't be enough memory to hold it.
> 
> Would it make sense to restrict the changes to modifying only the file offsets, while leaving the lengths as size_t?
> 
You are right. Widening the read/write length parameters was a leftover
patch from some experiments I did. I've reverted them and tested with a
32 GB image (sanboot over http) and it also works without those (length
parameter) patches. The other patches, as far as I can tell, are needed
to support http boot images > 2GB for 32-bit.

I will re-send the patches without the length parameters being modified.

Thanks,

- Johannes